Re: [Proposal] Allow users to specify multiple tables in VACUUM commands

Nathan Bossart <bossartn@amazon.com>

From: "Bossart, Nathan" <bossartn@amazon.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-09-08T17:05:14Z
Lists: pgsql-hackers

Attachments

On 9/8/17, 1:27 AM, "Michael Paquier" <michael.paquier@gmail.com> wrote:
> Thanks. This looks now correct to me. Except that:
> +           ereport(ERROR,
> +               (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> +                errmsg("column lists cannot have duplicate entries"),
> +                errhint("the column list specified for relation
> \"%s\" contains duplicates",
> +                   relation->relation->relname)));
> This should use ERRCODE_DUPLICATE_COLUMN.

Absolutely.  This is fixed in v3.

Nathan

Commits

  1. Allow multiple tables to be specified in one VACUUM or ANALYZE command.

  2. Give a better error for duplicate entries in VACUUM/ANALYZE column list.

  3. Reject ANALYZE commands during VACUUM FULL or another ANALYZE.