Re: [PATCH] plpython function causes server panic
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Hao Zhang <zhrt1446384557@gmail.com>, Andres Freund <andres@anarazel.de>,
pgsql-hackers@lists.postgresql.org
Date: 2024-03-22T15:51:00Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > On Fri, Dec 29, 2023 at 12:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Here's a draft patch along this line. Basically the idea is that >> subtransactions used for error control are now legal in parallel >> mode (including in parallel workers) so long as they don't try to >> acquire their own XIDs. I had to clean up some error handling >> in xact.c, but really this is a pretty simple patch. > I agree with the general direction. A few comments: Thanks for looking at this! I was hoping you'd review it, because I thought there was a pretty significant chance that I'd missed some fundamental reason it couldn't work. I feel better now about it being worth pursuing. I consider the patch draft quality at this point: I didn't spend much effort on docs or comments, and none on test cases. I'll work on those issues and come back with a v2. regards, tom lane
Commits
-
Allow "internal" subtransactions in parallel mode.
- 0075d78947e3 17.0 landed
-
Tighten up application of parallel mode checks.
- 94b4f7e2a635 9.6.0 cited