Horton

Thread

Commits

  1. Use the correct sizeof() in BufFileLoadBuffer

  1. benign bug in BufFileLoadBuffer / incorrect sizeof

    Tomas Vondra <tomas@vondra.me> — 2025-01-12T16:10:19Z

    Hi,

While experimenting with some changes in BufFile, I noticed a harmless
bug in BufFileLoadBuffer. It calls sizeof on the whole PGAlignedBuffer,
instead of just on the "data" field. It's benign because the "data" is
the largest part of the union, so the sizes are equal.

But it's still confusing, it took me a while my experimental patch
fails. So I think it'd be good to correct it.

regards

-- 
Tomas Vondra

  2. Re: benign bug in BufFileLoadBuffer / incorrect sizeof

    Daniel Gustafsson <daniel@yesql.se> — 2025-01-12T19:16:27Z

    > On 12 Jan 2025, at 17:10, Tomas Vondra <tomas@vondra.me> wrote:
> 
> Hi,
> 
> While experimenting with some changes in BufFile, I noticed a harmless
> bug in BufFileLoadBuffer. It calls sizeof on the whole PGAlignedBuffer,
> instead of just on the "data" field. It's benign because the "data" is
> the largest part of the union, so the sizes are equal.
> 
> But it's still confusing, it took me a while my experimental patch
> fails. So I think it'd be good to correct it.

Nice catch, patch LGTM.

--
Daniel Gustafsson