Horton

Re: Improve the granularity of PQsocketPoll's timeout parameter?

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-hackers@lists.postgresql.org, Tristan Partin <tristan@partin.io>, Robert Haas <robertmhaas@gmail.com>, Dominique Devienne <ddevienne@gmail.com>
Date: 2024-06-10T23:57:24Z
Lists: pgsql-hackers 
Jeff Davis <pgsql@j-davis.com> writes:
> I briefly skimmed the thread and didn't find the reason why the API
> requires an absolute time.

Because a common call pattern is to loop around PQsocketPoll calls.
In that scenario you generally want to nail down the timeout time
before starting the loop, not have it silently move forward after
any random event that breaks the current wait (EINTR for example).
pqSocketCheck and pqConnectDBComplete both rely on this.

			regards, tom lane

Commits

  1. Improve the granularity of PQsocketPoll's timeout parameter.