Horton

Re: Page Scan Mode in Hash Index

Jesper Pedersen <jesper.pedersen@redhat.com>

View thread View on postgr.es
From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-03-23T18:19:12Z
Lists: pgsql-hackers 
Hi,

On 03/23/2017 02:11 PM, Ashutosh Sharma wrote:
> On Thu, Mar 23, 2017 at 8:29 PM, Jesper Pedersen
> <jesper.pedersen@redhat.com> wrote:
>> 0001v2:
>>
>> In hashgettuple() you can remove the 'currItem' and 'offnum' from the 'else'
>> part, and do the assignment inside
>>
>>   if (so->numKilled < MaxIndexTuplesPerPage)
>>
>> instead.
>>
>
> Done. Please have a look into the attached v3 patch.
>
>>
>> No new comments for 0002 and 0003.
>
> okay. Thanks.
>

I'll keep the entry in 'Needs Review' if Alexander, or others, want to 
add their feedback.

(Best to post the entire patch series each time)

Best regards,
  Jesper

Commits

  1. Remove lsn from HashScanPosData.

  2. Fix trivial mistake in README.

  3. hash: Implement page-at-a-time scan.

  4. Reduce pinning and buffer content locking for btree scans.