Horton

Re: Keep compiler silence (clang 10, implicit conversion from 'long' to 'double' )

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Yuya Watari <watari.yuya@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@postgresql.org
Date: 2019-11-05T15:04:14Z
Lists: pgsql-hackers 
Yuya Watari <watari.yuya@gmail.com> writes:
> The added macro FLOAT8_FITS_IN_INT32() does not check NaN explicitly,
> but it sufficiently handles the case.

Really?  I don't think anything is guaranteed about how a NaN will
compare when using C's non-NaN-aware comparison operators.

My thought about this was to annotate the macros with a reminder
to also check for NaN if there's any possibility that the value
is NaN.

			regards, tom lane

Commits

  1. Fix integer-overflow edge case detection in interval_mul and pgbench.

  2. Change floating-point output format for improved performance.