Re: [PATCH] Implement INSERT SET syntax

Gareth Palmer <gareth@internetnz.net.nz>

From: Gareth Palmer <gareth@internetnz.net.nz>

To: movead li <movead.li@highgo.ca>

Cc: pgsql-hackers@lists.postgresql.org

Date: 2020-04-24T00:04:33Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add const qualifiers to internal range type APIs
- 73025140885c 13.0 cited

Attachments

insert-set-v7.patch (application/octet-stream) patch v7

Hi Movead,

> On 22/04/2020, at 2:40 PM, movead li <movead.li@highgo.ca> wrote:
> 
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            tested, passed
> 
> It builds failed by applying to the latest code version, and I try head
> '73025140885c889410b9bfc4a30a3866396fc5db' which work well.
> 
> The new status of this patch is: Waiting on Author

Thank you for the review, attached is v7 of the patch which should
apply correcly to HEAD.

This version now uses it's own production rule for the SET clause to
avoid the issue with MultiAssigmentRef nodes in the targetList.