Horton

Re: remove more archiving overhead

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Nathan Bossart <nathandbossart@gmail.com>, Noah Misch <noah@leadboat.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, robertmhaas@gmail.com, masao.fujii@oss.nttdata.com, pgsql-hackers@postgresql.org
Date: 2022-08-02T11:23:35Z
Lists: pgsql-hackers 
On 8/2/22 01:02, Nathan Bossart wrote:
> On Sat, Jul 30, 2022 at 11:51:56PM -0700, Noah Misch wrote:
>> Inviting the administrator to resolve things is more dangerous than just
>> returning true.  I recommend making this text more opinionated and simpler:
>> libraries must return true.  Alternately, if some library has found a good
>> reason to return false, this paragraph could give the reason.  I don't know of
>> such a reason, though.
> 
> Your suggestion seems reasonable to me.  I've attached a small patch.

+1. I think this is less confusing overall.

Regards,
-David

Commits

  1. Be more prescriptive in new doc about re-archiving of same WAL file.

  2. doc: Add note about re-archiving of same WAL files in docs.

  3. Reduce overhead of renaming archive status files.