Horton

Re: GIN predicate locking slows down valgrind isolationtests tremendously

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>, Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Teodor Sigaev <teodor@sigaev.ru>, Shubham Barai <shubhambaraiss@gmail.com>, Dmitry Ivanov <d.ivanov@postgrespro.ru>
Date: 2018-12-24T22:47:57Z
Lists: pgsql-hackers 
On 12/24/18 5:25 PM, Alexander Korotkov wrote:
> On Fri, Dec 21, 2018 at 1:50 AM Alexander Korotkov
> <a.korotkov@postgrespro.ru> wrote:
>> чт, 20 дек. 2018 г., 2:22 Andres Freund andres@anarazel.de:
>>> On 2018-12-03 16:07:40 -0800, Andres Freund wrote:
>>>> As far as I can tell that increase comes laregely from the new GIN
>>>> tests.  Could one of you please look at keeping the test time increase
>>>> to something more reasonable?
>>> Ping?
>>>
>>> It's also one of the slowest tests outside of valgrind...
>> I'm going to take a look on that.
> BTW, patch for reducing isolation testing for gin predicate locking is
> attached.  Could anybody check its execution time with valgrind (and
> compare with execution time of previous test suite)?



Will try if I get some time to spare in the next 72 hours or so


cheers


andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Reduce length of GIN predicate locking isolation test suite

  2. Remove entry tree root conflict checking from GIN predicate locking