Re: [RFC] Removing "magic" oids

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2018-11-21T18:17:57Z
Lists: pgsql-hackers
On 11/20/18 7:07 PM, Andres Freund wrote:
>
>
> Let's see what I broke :/
>


pg_upgrade against old versions, by the look of it. Even after I drop 
oids from user tables, I get errors like this when running pg_dumpall 
against a pg_upgraded REL_9_4_STABLE datadir:


2018-11-21 13:01:58.582 EST [11861] ERROR:  large object 10 does not exist
2018-11-21 13:01:58.637 EST [11686] ERROR:  could not open file 
"base/17486/2840_vm": No such file or directory
2018-11-21 13:01:58.637 EST [11686] CONTEXT:  writing block 0 of 
relation base/17486/2840_vm
2018-11-21 13:01:59.638 EST [11686] ERROR:  could not open file 
"base/17486/2840_vm": No such file or directory
2018-11-21 13:01:59.638 EST [11686] CONTEXT:  writing block 0 of 
relation base/17486/2840_vm
2018-11-21 13:01:59.638 EST [11686] WARNING:  could not write block 0 of 
base/17486/2840_vm
2018-11-21 13:01:59.638 EST [11686] DETAIL:  Multiple failures --- write 
error might be permanent.
2018-11-21 13:02:00.493 EST [11688] ERROR:  could not open file 
"global/1262": No such file or directory
2018-11-21 13:02:00.639 EST [11686] ERROR:  could not open file 
"base/17486/2840_vm": No such file or directory
2018-11-21 13:02:00.639 EST [11686] CONTEXT:  writing block 0 of 
relation base/17486/2840_vm
2018-11-21 13:02:00.639 EST [11686] WARNING:  could not write block 0 of 
base/17486/2840_vm
2018-11-21 13:02:00.639 EST [11686] DETAIL:  Multiple failures --- write 
error might be permanent.
2018-11-21 13:02:01.495 EST [11688] ERROR:  could not open file 
"global/1262": No such file or directory
2018-11-21 13:02:01.640 EST [11686] ERROR:  could not open file 
"base/17486/2840_vm": No such file or directory
2018-11-21 13:02:01.640 EST [11686] CONTEXT:  writing block 0 of 
relation base/17486/2840_vm
2018-11-21 13:02:01.641 EST [11686] WARNING:  could not write block 0 of 
base/17486/2840_vm
2018-11-21 13:02:01.641 EST [11686] DETAIL:  Multiple failures --- write 
error might be permanent.
2018-11-21 13:02:02.496 EST [11688] ERROR:  could not open file 
"global/1262": No such file or directory
2018-11-21 13:02:02.642 EST [11686] ERROR:  could not open file 
"base/17486/2840_vm": No such file or directory
2018-11-21 13:02:02.642 EST [11686] CONTEXT:  writing block 0 of 
relation base/17486/2840_vm
2018-11-21 13:02:02.642 EST [11686] WARNING:  could not write block 0 of 
base/17486/2840_vm
2018-11-21 13:02:02.642 EST [11686] DETAIL:  Multiple failures --- write 
error might be permanent.
2018-11-21 13:02:03.497 EST [11688] ERROR:  could not open file 
"global/1262": No such file or directory
2018-11-21 13:02:03.643 EST [11686] ERROR:  could not open file 
"base/17486/2840_vm": No such file or directory
2018-11-21 13:02:03.643 EST [11686] CONTEXT:  writing block 0 of 
relation base/17486/2840_vm
2018-11-21 13:02:03.643 EST [11686] WARNING:  could not write block 0 of 
base/17486/2840_vm
2018-11-21 13:02:03.643 EST [11686] DETAIL:  Multiple failures --- write 
error might be permanent.
2018-11-21 13:02:04.498 EST [11688] ERROR:  could not open file 
"global/1262": No such file or directory
2018-11-21 13:02:04.644 EST [11686] ERROR:  could not open file 
"base/17486/2840_vm": No such file or directory
2018-11-21 13:02:04.644 EST [11686] CONTEXT:  writing block 0 of 
relation base/17486/2840_vm
2018-11-21 13:02:04.644 EST [11686] WARNING:  could not write block 0 of 
base/17486/2840_vm
2018-11-21 13:02:04.644 EST [11686] DETAIL:  Multiple failures --- write 
error might be permanent.
2018-11-21 13:02:05.499 EST [11688] ERROR:  could not open file 
"global/1262": No such file or directory
2018-11-21 13:02:05.645 EST [11686] ERROR:  could not open file 
"base/17486/2840_vm": No such file or directory
2018-11-21 13:02:05.645 EST [11686] CONTEXT:  writing block 0 of 
relation base/17486/2840_vm
2018-11-21 13:02:05.645 EST [11686] WARNING:  could not write block 0 of 
base/17486/2840_vm
2018-11-21 13:02:05.645 EST [11686] DETAIL:  Multiple failures --- write 
error might be permanent.
2018-11-21 13:02:06.501 EST [11688] ERROR:  could not open file 
"global/1262": No such file or directory
2018-11-21 13:02:06.646 EST [11686] ERROR:  could not open file 
"base/17486/2840_vm": No such file or directory
2018-11-21 13:02:06.646 EST [11686] CONTEXT:  writing block 0 of 
relation base/17486/2840_vm
2018-11-21 13:02:06.646 EST [11686] WARNING:  could not write block 0 of 
base/17486/2840_vm
2018-11-21 13:02:06.646 EST [11686] DETAIL:  Multiple failures --- write 
error might be permanent.
2018-11-21 13:02:07.502 EST [11688] ERROR:  could not open file 
"global/1262": No such file or directory
2018-11-21 13:02:07.648 EST [11686] ERROR:  could not open file 
"base/17486/2840_vm": No such file or directory
2018-11-21 13:02:07.648 EST [11686] CONTEXT:  writing block 0 of 
relation base/17486/2840_vm
2018-11-21 13:02:07.648 EST [11686] WARNING:  could not write block 0 of 
base/17486/2840_vm
2018-11-21 13:02:07.648 EST [11686] DETAIL:  Multiple failures --- write 
error might be permanent.
2018-11-21 13:02:08.503 EST [11688] ERROR:  could not open file 
"global/1262": No such file or directory
2018-11-21 13:02:08.649 EST [11686] ERROR:  could not open file 
"base/17486/2840_vm": No such file or directory
2018-11-21 13:02:08.649 EST [11686] CONTEXT:  writing block 0 of 
relation base/17486/2840_vm
2018-11-21 13:02:08.649 EST [11686] WARNING:  could not write block 0 of 
base/17486/2840_vm
2018-11-21 13:02:08.649 EST [11686] DETAIL:  Multiple failures --- write 
error might be permanent.


cheers


andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Commits

  1. Revive test of concurrent OID generation.

  2. Fix typo introduced in 578b229718.

  3. Fix pg_upgrade for oid removal.

  4. Fix sepgsql compile error caused by oid removal.

  5. Remove WITH OIDS support, change oid catalog column visibility.