Horton

Re: ECPG Refactor: move sqlca variable in ecpg_log()

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: "Yuto Sasaki (Fujitsu)" <sasaki.yuto-00@fujitsu.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2024-10-18T17:43:45Z
Lists: pgsql-hackers 
Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> I've attached the latest version of the patch, now including the commit log.
> Unless there are any objections, I'll proceed with committing it.

LGTM.  Maybe move down the sqlca variable declaration, so that the
declarations still match the order in which the variables are
initialized?  That's just cosmetic of course.

			regards, tom lane

Commits

  1. ecpg: Refactor ecpg_log() to skip unnecessary calls to ECPGget_sqlca().