Horton

Re: check_recovery_target_lsn() does a PG_CATCH without a throw

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2019-06-24T21:27:26Z
Lists: pgsql-hackers 
On 2019-06-24 06:06, Michael Paquier wrote:
> -       if (strcmp(*newval, "epoch") == 0 ||
> -           strcmp(*newval, "infinity") == 0 ||
> -           strcmp(*newval, "-infinity") == 0 ||
> Why do you remove these?  They should still be rejected because they
> make no sense as recovery targets, no?

Yeah but the new code already rejects those anyway.  Note how
timestamptz_in() has explicit switch cases to accept those, and we
didn't carry those over into check_recovery_time().

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Don't call data type input functions in GUC check hooks