Horton

Re: further #include cleanup (IWYU)

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-01-29T11:35:00Z
Lists: pgsql-hackers 
On 27.01.25 15:10, Matthias van de Meent wrote:
> On Wed, 6 Nov 2024 at 11:50, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> Seeing no further comments (or any easy alternatives), I have committed
>> this last patch as is.
> 
> I just noticed that the #define for MaxArraySize in utils/array.h uses
> MaxAllocSize without including the utils/memutils.h header. Is that on
> purpose and is the user expected to include both headers, or should
> utils/memutils.h be included in utils/array.h?

I have found a number of cases like this, where a macro definition in a 
header uses a symbol that is defined in another header that is not 
included.  This is not something that the IWYU tool set can track.

In general, this kind of thing is probably best avoided, but it would 
probably require individual investigation of each case.

Commits

  1. Remove unused #include's from bin .c files

  2. Remove unused #include's from contrib, pl, test .c files

  3. Remove unused #include's from backend .c files

  4. Replace most usages of ntoh[ls] and hton[sl] with pg_bswap.h.