Horton

Re: master make check fails on Solaris 10

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Marina Polyakova <m.polyakova@postgrespro.ru>, "Victor Wagner *EXTERN*" <vitus@wagner.pp.ru>, Andres Freund <andres@anarazel.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2018-01-18T18:03:00Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Jan 18, 2018 at 12:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Really, this is something that the compiler ought to do for us, IMO.
>> If the gcc guys don't want to be bothered, OK, but that tells you more
>> about the priority they place on SPARC support than anything else.

> Of course, the same accusation could be leveled at us.  We don't
> require int128 support for correctness; we just use it for performance
> where it's available and works the way we want.  Prolly, that means
> mainstream platforms.  If we wanted to work harder, we could get it
> working in other places too.  Or some other fix that delivers much of
> the same performance benefit.

Sure.  Part of the equation here is that (IMO anyway) int128 isn't
sufficiently performance-critical to us to justify putting enormous
amounts of work into trying to make it go on non-mainstream platforms.
It's possible that that could change in future ... but if part of the
cost is notational changes that make it harder and more bug-prone
to use int128 at all, then I daresay int128 will never become that
performance-critical, because it would always remain a niche thing.

			regards, tom lane

Commits

  1. Extend configure's __int128 test to check for a known gcc bug.

  2. Reorder C includes

  3. Ability to advance replication slots

  4. doc: add JSON acronym

  5. Expression evaluation based aggregate transition invocation.

  6. Change some bogus PageGetLSN calls to BufferGetLSNAtomic

  7. Prevent int128 from requiring more than MAXALIGN alignment.

  8. Rearrange c.h to create a "compiler characteristics" section.

  9. Make OWNER TO subcommand mention consistent