Re: WIP Patch: Selective binary conversion of CSV file foreign tables

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: "Etsuro Fujita" <fujita.etsuro@lab.ntt.co.jp>

Cc: "'Kohei KaiGai'" <kaigai@kaigai.gr.jp>, "'Robert Haas'" <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org

Date: 2012-07-12T20:30:14Z

Lists: pgsql-hackers

"Etsuro Fujita" <fujita.etsuro@lab.ntt.co.jp> writes:
> Besides the revision, I modified check_selective_binary_conversion() to run
> heap_close() in the whole-row-reference case.  Attached is an updated version of
> the patch.

Applied with minor, mostly-cosmetic revisions.  I did fix
check_selective_binary_conversion to not continue touching the
relation's tupledesc after heap_close.  Also I thought
"convert_selectively" was a better name for the hidden COPY option.

			regards, tom lane