Horton

Re: A bug when use get_bit() function for a long bytea string

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "movead.li@highgo.ca" <movead.li@highgo.ca>
Cc: "Daniel Verite" <daniel@manitou-mail.org>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>, "ashutosh.bapat" <ashutosh.bapat@2ndquadrant.com>
Date: 2020-04-07T15:02:43Z
Lists: pgsql-hackers 
"movead.li@highgo.ca" <movead.li@highgo.ca> writes:
> After several patch change by hacker's proposal, I think it's ready to
> commit, can we commit it before doing the code freeze for pg-13?

It would be easier to get this done if you had addressed any of the
objections to the patch as given.  Integer-overflow handling is still
missing, and you still are assuming that it's okay to change catalog
entries in released branches.

			regards, tom lane

Commits

  1. Adjust bytea get_bit/set_bit to cope with bytea strings > 256MB.

  2. Adjust bytea get_bit/set_bit to use int8 not int4 for bit numbering.