Horton

Re: Inconsistent RestrictInfo serial numbers

Andrei Lepikhov <lepihov@gmail.com>

View thread View on postgr.es
From: Andrei Lepikhov <lepihov@gmail.com>
To: Richard Guo <guofenglinux@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-10-09T03:15:06Z
Lists: pgsql-hackers 
On 10/8/24 18:20, Richard Guo wrote:
> To fix, I think we can reset the root->last_rinfo_serial counter after
> generating the additional constant-FALSE RestrictInfo.  Please see
> attached.
Thanks for the job!
The approach will work, no doubt. But why are you using such a wordy 
approach with save_last_rinfo_serial? I'd say it is better to invent a 
function like make_rinfo_variant() or something like that and explicitly 
set rinfo_serial. It will be easier to read and understand in the 
future, won't it?

-- 
regards, Andrei Lepikhov

Commits

  1. Fix inconsistent RestrictInfo serial numbers

  2. Recalculate where-needed data accurately after a join removal.

  3. Add better handling of redundant IS [NOT] NULL quals