Horton

Re: Show various offset arrays for heap WAL records

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Peter Geoghegan <pg@bowt.ie>, Melanie Plageman <melanieplageman@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2023-07-10T07:44:27Z
Lists: pgsql-hackers

Attachments

On 12/04/2023 01:29, Peter Geoghegan wrote:
> Thanks for your help with the follow-up work. Seems like we're done
> with this now.

This is still listed in the July commitfest; is there some work remaining?

I'm late to the party, but regarding commit c03c2eae0a, which added the 
guidelines for writing formatting desc functions:

You moved the comment from rmgrdesc_utils.c into rmgrdesc_utils.h, but I 
don't think that was a good idea. Our usual convention is to have the 
function comment in the .c file, not at the declaration in the header 
file. When I want to know what a function does, I jump to the .c file, 
and might miss the comment in the header entirely.

Let's add a src/backend/access/rmgrdesc/README file. We don't currently 
have any explanation anywhere why the rmgr desc functions are in a 
separate directory. The README would be a good place to explain that, 
and to have the formatting guidelines. See attached.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

  1. Merge prune, freeze and vacuum WAL record formats

  2. Add rmgrdesc README

  3. Refine the guidelines for rmgrdesc authors.

  4. Fix Heap rmgr's desc output for infobits arrays.

  5. Clarify nbtree posting list update desc issue.

  6. Fix nbtree posting list update desc output.

  7. Set cutoff xmin more aggressively when vacuuming a temporary table.