Re: Hashed IN only applied to first encountered IN

David Geier <geidav.pg@gmail.com>

From: David Geier <geidav.pg@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-04-02T09:44:28Z
Lists: pgsql-hackers
Great!

Thank you!

On 4/2/2025 1:00 AM, David Rowley wrote:
> On Wed, 2 Apr 2025 at 01:31, David Rowley <dgrowleyml@gmail.com> wrote:
>> On Wed, 2 Apr 2025 at 00:51, David Geier <geidav.pg@gmail.com> wrote:
>>> The hashed IN optimization is only applied to the first encountered
>>> ScalarArrayOpExpr during the expression tree traversal in
>>> convert_saop_to_hashed_saop_walker(). Reason being that the walker
>>> returns true which aborts the traversal.
>>> I've also attached a patch with a fix.
>> Thanks for the report and fix.  On first inspection your patch looks
>> fine.  I'll have a closer look tomorrow.
> I've now pushed and backpatched the relevant portion of this back to v14.
>
> Thanks again.
>
> David



Commits

  1. Fix planner's failure to identify multiple hashable ScalarArrayOpExprs