Re: Clean up MinGW def file generation
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@postgresql.org
Date: 2019-10-20T08:26:40Z
Lists: pgsql-hackers
On 2019-10-18 15:00, Tom Lane wrote: > Yeah, the comment that Peter complained about is mine. I believe the > desire to avoid depending on "sed" at build time was focused on our > old support for building libpq with Borland C (and not much else). > Since this makefile infrastructure is now only used for MinGW, I agree > we ought to be able to quit shipping those files in tarballs. Yeah, it all makes sense now. I have committed my patch now. > I think there could be some .gitignore cleanup done along with this. > Notably, I see exclusions for /exports.list in several places, but no > other references to that name --- isn't that an intermediate file that > we used to generate while creating these files? exports.list is built from exports.txt on non-Windows platforms and AFAICT it is not cleaned up as an intermediate file. So I think the current arrangement is correct. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Remove libpq-dist.rc
- 508e84d79910 13.0 landed
-
Clean up MinGW def file generation
- ea9e06ac66d3 13.0 landed
-
Refactor the code that creates the shared library export files to appear
- a1d5d8574751 8.4.0 cited
-
Make a separate win32 debug DLL along with the non-debug version:
- 53cd7cd8a916 8.0.0 cited