Horton

Re: Remove MSVC scripts from the tree

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Andres Freund <andres@anarazel.de>, vignesh C <vignesh21@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Shubham Khanna <khannashubham1197@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-20T15:43:55Z
Lists: pgsql-hackers

Attachments

On 20.12.23 12:40, Andres Freund wrote:
> Hm, or perhaps we should just get rid of sed use altogether. The sepgsql case
> is trivially translateable to perl, and postprocess_dtrace.sed isn't
> much harder.

Maybe yeah, but also it seems fine as is and we can easily fix the 
present issue ...

> OTOH, I actually don't think it's valid to not have sed when you have
> dtrace. Erroring out in a weird way in such an artificially constructed test
> doesn't really seem like a problem.

Agreed.  So let's just make it not-required, and that should work.

Updated patch set attached.

Commits

  1. Make win32tzlist.pl checkable again

  2. meson: Make gzip and tar optional

  3. meson: Make sed optional

  4. Remove MSVC scripts

  5. Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl