Re: Let's get rid of serial_schedule
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-05-11T19:38:55Z
Lists: pgsql-hackers
Attachments
- delete-serial_schedule-2.patch (text/x-diff) patch
Heikki Linnakangas <hlinnaka@iki.fi> writes: > On 11/05/2021 21:58, Tom Lane wrote: >> + # for backwards compatibility, interpret "serial" as parallel tests > This comment isn't great, IMHO. How about: > # for backwards comopatibility, "serial" runs the tests in > # parallel_schedule one by one. Yeah, and on closer inspection, the code is wrong too :-(. I'd confused --max-concurrent-tests with --max-connections, but they're different. Also, I did take a look at pg_regress.c, and confirmed my fear that getting it to duplicate the serial output style would be kind of messy. regards, tom lane
Commits
-
Fix vcregress.pl's ancient misspelling of --max-connections.
- 0b85fa93e457 14.0 landed
-
Get rid of the separate serial_schedule list of tests.
- 1df3555acc78 14.0 landed