Re: contrib/sepgsql regression tests have been broken for months
Joe Conway <mail@joeconway.com>
From: Joe Conway <mail@joeconway.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
Jacob Champion <jacob.champion@enterprisedb.com>,
pgsql-hackers@lists.postgresql.org
Date: 2025-10-30T13:29:46Z
Lists: pgsql-hackers
On 10/29/25 19:36, Tom Lane wrote: > I poked around in the buildfarm client and was surprised to > find that the old TestSepgsql.pm module does in fact expect > to have sudo privileges, and it seems to install, enable, > and eventually remove the sepgsql-regtest kernel module. > > I thought we were trying to get rid of that requirement though. > (For sure, you won't ever see me running the buildfarm > client under a sudo-capable account.) I think the new idea > is to leave the module installed and active, which is kind > of problematic if we want to also use TestSepgsql.pm in the > back branches. > > I also don't quite understand how 001_sepgsql.pl's "checking for > sepgsql-regtest policy" test is passing if the previous > TestSepgsql.pm run removed that module ... I suppose one solution is to create a new buildfarm animal and then use rhino only for <= pg17 and <rhino-prime> only for pg18+ -- Joe Conway PostgreSQL Contributors Team Amazon Web Services: https://aws.amazon.com
Commits
-
Update expected output for contrib/sepgsql's regression tests.
- 67ef5575ccb0 18.1 landed
- 0758111f5d35 19 (unreleased) landed
-
Print out error position for some ALTER TABLE ALTER COLUMN type
- 65281391a937 18.0 cited