Horton

Re: RTE_NAMEDTUPLESTORE, enrtuples and comments

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, Noah Misch <noah@leadboat.com>, Kevin Grittner <kgrittn@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Andrew Gierth <andrew@tao11.riddles.org.uk>
Date: 2017-06-13T14:05:07Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> Perhaps this is a silly question, but I don't particularly see what's
> wrong with:

> 3. Do nothing.

Well, the fundamental problem is that the RTE is a lousy place to keep
rowcount estimates.  That breaks assorted desirable properties like
querytrees being readonly to planning/execution (not that we don't
end up copying them anyway, but up to now that's been because of bad
implementation not because the representation was broken by design).

I agree that it's probably not so badly broken that we have to fix it
in time for v10, but this is not where we want to be in the long run.

			regards, tom lane

Commits

  1. Fix problems related to RangeTblEntry members enrname and enrtuples.

  2. Add infrastructure to support EphemeralNamedRelation references.