Re: PATCH: add "--config-file=" option to pg_rewind
Gunnar "Nick" Bluth <gunnar.bluth@pro-open.de>
From: "Gunnar \"Nick\" Bluth" <gunnar.bluth@pro-open.de>
To: Daniel Gustafsson <daniel@yesql.se>,
Alexander Kukushkin <cyberdemn@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>,
"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2022-02-24T13:43:17Z
Lists: pgsql-hackers
Am 24.02.2022 um 14:08 schrieb Daniel Gustafsson: >> On 24 Feb 2022, at 10:27, Alexander Kukushkin <cyberdemn@gmail.com> wrote: >> >> Hello Gunnar, >> >> On Thu, 24 Feb 2022 at 10:03, Aleksander Alekseev <aleksander@timescale.com> wrote: >> >>> wants to use the "-c" option on a typical Debian/Ubuntu installation >>> (where the config resides below /etc/postgresql/), pg_rewind needs a way >>> to be told where the postgresql.conf actually is. >>> >>> The attached patch implements this as an option. >>> >>> [...] >> >> Good catch! >> >> Yeah, it is a known problem, and there was already another patch trying to address it [1]. > > There is yet another related patch which provides a parameter to pass in > restore_command in cases where postgresq.conf isn't reachable: > > https://commitfest.postgresql.org/37/3213/ That looks just as good to me, and it already has tests, so I'll happily step down! (Note to myself: check the CF first next time ;-) -- Gunnar "Nick" Bluth Eimermacherweg 106 D-48159 Münster Mobil +49 172 8853339 Email: gunnar.bluth@pro-open.de __________________________________________________________________________ "Ceterum censeo SystemD esse delendam" - Cato
Commits
-
Add option --config-file to pg_rewind
- 0d5c387573be 15.0 landed
-
Rework internal command generation of pg_rewind
- a33e17f21054 15.0 landed