Horton

Re: BUG #17212: pg_amcheck fails on checking temporary relations

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, Peter Geoghegan <pg@bowt.ie>, Robert Haas <robertmhaas@gmail.com>, Pavel Borisov <pashkin.elfe@gmail.com>, Alexander Lakhin <exclusion@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-10-14T21:39:02Z
Lists: pgsql-bugs, pgsql-hackers 
Mark Dilger <mark.dilger@enterprisedb.com> writes:
>> On Oct 14, 2021, at 2:13 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> (b) Wouldn't finish()ing that connection cause the temp tables to be
>> dropped, negating the entire point of the test?

> The finish() would have to be the last line of the test.
> ...
> I'm curious if the test is indicating something about the underlying test system.  Only one other test in the tree uses background_psql().  I was hoping Andrew would have something to say about whether this is a bug with that function or just user error on my part.

Neither of these things could explain the problem at hand, AFAICS,
because it's failing to start up the standby.

			regards, tom lane

Commits

  1. Remove unstable pg_amcheck tests.

  2. pg_amcheck: avoid unhelpful verification attempts.

  3. amcheck: Skip unlogged relations in Hot Standby.

  4. amcheck: Skip unlogged relations during recovery.