Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Disallow generated columns in COPY WHERE clause

  2. Replace pg_restrict by standard restrict

  1. warning on the current head

    Rafia Sabih <rafia.pghackers@gmail.com> — 2025-11-06T16:47:38Z

    I am seeing following warning,

In file included from specscanner.c:11:
In file included from ../../../src/include/postgres_fe.h:28:
../../../src/include/c.h:113:9: warning: 'pg_restrict' macro redefined
[-Wmacro-redefined]
  113 | #define pg_restrict restrict
      |         ^
../../../src/include/pg_config.h:802:9: note: previous definition is here
  802 | #define pg_restrict __restrict
      |         ^
1 warning generated.

at
commit aa606b9316a334cbc8c48560c72235f9e48e47bf
Author: Peter Eisentraut <peter@eisentraut.org>
Date:   Thu Nov 6 11:52:47 2025 +0100
    Disallow generated columns in COPY WHERE clause

Is someone else also seeing this or I am doing something wrong.

-- 
Regards,
Rafia Sabih
CYBERTEC PostgreSQL International GmbH

  2. Re: warning on the current head

    Álvaro Herrera <alvherre@kurilemu.de> — 2025-11-06T16:58:50Z

    On 2025-Nov-06, Rafia Sabih wrote:

> I am seeing following warning,
> 
> In file included from specscanner.c:11:
> In file included from ../../../src/include/postgres_fe.h:28:
> ../../../src/include/c.h:113:9: warning: 'pg_restrict' macro redefined
> [-Wmacro-redefined]
>   113 | #define pg_restrict restrict
>       |         ^
> ../../../src/include/pg_config.h:802:9: note: previous definition is here
>   802 | #define pg_restrict __restrict
>       |         ^
> 1 warning generated.
> 
> at
> commit aa606b9316a334cbc8c48560c72235f9e48e47bf
> Author: Peter Eisentraut <peter@eisentraut.org>
> Date:   Thu Nov 6 11:52:47 2025 +0100
>     Disallow generated columns in COPY WHERE clause
> 
> Is someone else also seeing this or I am doing something wrong.

Hmm, maybe you need to run configure again, perhaps after `make
distclean`?  In pg_config.h.in, the "#undef pg_restrict" line was by
commit f0f2c0c1aef9 (Oct. 29), so the Nov. 6 commit should not have
caused problems, unless your pg_config.h is out of date.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/

  3. Re: warning on the current head

    Viktor Holmberg <v@viktorh.net> — 2025-11-19T19:43:52Z

    On 6 Nov 2025 at 17:59 +0100, Álvaro Herrera <alvherre@kurilemu.de>, wrote:
> On 2025-Nov-06, Rafia Sabih wrote:
>
> > I am seeing following warning,
> >
> > In file included from specscanner.c:11:
> > In file included from ../../../src/include/postgres_fe.h:28:
> > ../../../src/include/c.h:113:9: warning: 'pg_restrict' macro redefined
> > [-Wmacro-redefined]
> > 113 | #define pg_restrict restrict
> > | ^
> > ../../../src/include/pg_config.h:802:9: note: previous definition is here
> > 802 | #define pg_restrict __restrict
> > | ^
> > 1 warning generated.
> >
> > at
> > commit aa606b9316a334cbc8c48560c72235f9e48e47bf
> > Author: Peter Eisentraut <peter@eisentraut.org>
> > Date: Thu Nov 6 11:52:47 2025 +0100
> > Disallow generated columns in COPY WHERE clause
> >
> > Is someone else also seeing this or I am doing something wrong.
>
> Hmm, maybe you need to run configure again, perhaps after `make
> distclean`? In pg_config.h.in, the "#undef pg_restrict" line was by
> commit f0f2c0c1aef9 (Oct. 29), so the Nov. 6 commit should not have
> caused problems, unless your pg_config.h is out of date.
>
> --
> Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
>
For anyone else experiencing this - I had the same problem. make distclean and re-configure solved it as Álvaro suggested.

  4. Re: warning on the current head

    Michael Paquier <michael@paquier.xyz> — 2025-11-24T22:00:41Z

    On Wed, Nov 19, 2025 at 08:43:52PM +0100, Viktor Holmberg wrote:
> For anyone else experiencing this - I had the same problem. make
> distclean and re-configure solved it as Álvaro suggested.

Another one, which is more drastic for builds inside the tree, is the
following:
git clean -dxf

I have been relying on this recipe for years to start builds from an
entirely "fresh" state.
--
Michael