Horton

Thread

Commits

  1. Fix function signatures of pageinspect in documentation

  1. Small doc fix for pageinspect

    Laurenz Albe <laurenz.albe@cybertec.at> — 2019-03-07T20:00:24Z

    I noticed today that the signature for two functions is wrong
in the documentation:

- "heap_page_item_attrs" has the argument order and return type wrong
  and is lacking types

- "tuple_data_split" is lacking the type for "rel_oid"

Patch attached.

This should be backpatched down to 9.6 where the functions have been added.

Yours,
Laurenz Albe

  2. Re: Small doc fix for pageinspect

    Michael Paquier <michael@paquier.xyz> — 2019-03-08T06:13:00Z

    On Thu, Mar 07, 2019 at 09:00:24PM +0100, Laurenz Albe wrote:
> This should be backpatched down to 9.6 where the functions have been
> added.

Thanks, applied.  The second argument name of heap_page_item_attrs is
actually "page", and not "t_data", so both your patch and the docs
were wrong on this point.
--
Michael

  3. Re: Small doc fix for pageinspect

    Laurenz Albe <laurenz.albe@cybertec.at> — 2019-03-08T09:15:21Z

    Michael Paquier wrote:
> On Thu, Mar 07, 2019 at 09:00:24PM +0100, Laurenz Albe wrote:
> > This should be backpatched down to 9.6 where the functions have been
> > added.
> 
> Thanks, applied.  The second argument name of heap_page_item_attrs is
> actually "page", and not "t_data", so both your patch and the docs
> were wrong on this point.

Thanks, and pardon the sloppiness.

Yours,
Laurenz Albe