Horton

Re: SQL:2011 application time

Paul A Jungwirth <pj@illuminatedcomputing.com>

View thread
From: Paul Jungwirth <pj@illuminatedcomputing.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: jian he <jian.universality@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, vignesh C <vignesh21@gmail.com>
Date: 2025-01-03T01:47:02Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Rename gist stratnum support function

  2. Remove support for temporal RESTRICT foreign keys

  3. Cache NO ACTION foreign keys separately from RESTRICT foreign keys

  4. Fix NO ACTION temporal foreign keys when the referenced endpoints change

  5. Improve whitespace in without_overlaps test

  6. Tests for logical replication with temporal keys

  7. Support for GiST in get_equal_strategy_number()

  8. Make the conditions in IsIndexUsableForReplicaIdentityFull() more explicit

  9. Replace get_equal_strategy_number_for_am() by get_equal_strategy_number()

  10. Improve internal logical replication error for missing equality strategy

  11. Simplify IsIndexUsableForReplicaIdentityFull()

  12. Fix ALTER TABLE / REPLICA IDENTITY for temporal tables

  13. doc: Update pg_constraint.conexclop docs for WITHOUT OVERLAPS

  14. doc: Add PERIOD to ALTER TABLE reference docs

  15. doc: Add WITHOUT OVERLAPS to ALTER TABLE reference docs

  16. Add temporal FOREIGN KEY contraints

  17. Add temporal PRIMARY KEY and UNIQUE constraints

  18. Add stratnum GiST support function

  19. Avoid crashing when a JIT-inlined backend function throws an error.

  20. Revert temporal primary keys and foreign keys

  21. Fix ON CONFLICT DO NOTHING/UPDATE for temporal indexes

  22. Add test for REPLICA IDENTITY with a temporal key

  23. Use half-open interval notation in without_overlaps tests

  24. Use daterange and YMD in without_overlaps tests instead of tsrange.

  25. Rename pg_constraint.conwithoutoverlaps to conperiod

  26. Fix comment on gist_stratnum_btree

  27. Add missing TAP test name

  28. Improve error handling of HMAC computations

  29. Rename functions to avoid future conflicts

Attachments

On 12/10/24 06:40, Peter Eisentraut wrote:
> On 07.12.24 20:29, Paul Jungwirth wrote:
>> These five patches all look good to me.
>>
>> Note that my tests already include a section for REPLICA IDENTITY FULL, which passed. But the 
>> subscriber was using a SeqScan to look up tuples to update.
>>
>> Here are the steps (mostly just because it was confusing for me at first): First in 
>> FindUsableIndexForReplicaIdentityFull, we would call IsIndexUsableForReplicaIdentityFull, get back 
>> false, and decide there was no index to use. Then in FindReplTupleInLocalRel, localidxoid was 0, 
>> so we woudln't call IsIndexUsableForReplicaIdentityFull at all.
>>
>> After applying the five patches, I can see that we choose the index and call 
>> IsIndexUsableForReplicaIdentityFull from both sites. This should make applying changes a lot faster.
> 
> I have committed these.  I will continue with reviewing v45-0002 and following now.

Here is a rebase for the remaining patches. There are some small changes, but almost all the work 
was fixing the final PERIOD patch (mostly to work with the new cataloged NOT NULL code).

The most important patches are the first two, since they fix bugs in the already-committed FK code.

I'd love to see FOR PORTION OF get into v18 also, but I'm not sure how much work remains there. It 
don't think I've received feedback from a committer yet. It felt ready to commit to me, but after 
the FK fixes here I don't like how I'm getting both an operator and a proc for intersection, in 
different places. It seems like I should be able to make do with just one in all places. But since 
intersect is neither a search operator nor an ordering operator, it can't appear in pg_amop, so you 
can't look it up by stratnum. Maybe the intersect support func should return an operator oid, not a 
proc oid, and then I can use pg_operator.oprcode to call its proc directly. If that sounds good I'll 
make the changes.

Rebased to e28033fe1a.

-- 
Paul              ~{:-)
pj@illuminatedcomputing.com