Horton

Re: Replication vs. float timestamps is a disaster

Joshua D. Drake <jd@commandprompt.com>

View thread View on postgr.es
From: "Joshua D. Drake" <jd@commandprompt.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>
Cc: Jim Nasby <Jim.Nasby@BlueTreble.com>, Petr Jelinek <petr.jelinek@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-02-28T01:00:23Z
Lists: pgsql-hackers 
On 02/22/2017 02:45 PM, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2017-02-22 08:43:28 -0500, Tom Lane wrote:
>>> (To be concrete, I'm suggesting dropping --disable-integer-datetimes
>>> in HEAD, and just agreeing that in the back branches, use of replication
>>> protocol with float-timestamp servers is not supported and we're not
>>> going to bother looking for related bugs there.  Given the lack of field
>>> complaints, I do not believe anyone cares.)
>
> What I *am* willing to spend time on is removing float-timestamp code
> in HEAD.  I've not yet heard anybody speak against doing that (or at
> least, nothing I interpreted as a vote against it).  If I've not heard
> any complaints by tomorrow, I'll get started on that.

Rip it out!

Sincerely,

JD


-- 
Command Prompt, Inc.                  http://the.postgres.company/
                         +1-503-667-4564
PostgreSQL Centered full stack support, consulting and development.
Everyone appreciates your honesty, until you are honest with them.
Unless otherwise stated, opinions are my own.

Commits

  1. Consistently declare timestamp variables as TimestampTz.

  2. Remove now-dead code for !HAVE_INT64_TIMESTAMP.

  3. Remove pg_control's enableIntTimes field.

  4. De-support floating-point timestamps.

  5. Make integer_datetimes the default for MSVC even if not mentioned in config.pl.

  6. Enable 64-bit integer datetimes by default, per previous discussion.