Re: Fix port/pg_iovec.h building extensions on x86_64-darwin

Wolfgang Walther <walther@technowledgy.de>

From: Wolfgang Walther <walther@technowledgy.de>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: pgsql-hackers@lists.postgresql.org

Date: 2024-11-09T11:06:07Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix sign-compare warnings in pg_iovec.h.
- 0fa688406595 18.0 landed
- 0a883a067bd7 17.1 landed

Thomas Munro:
> Out of curiosity, is nixos deliberately using an old macOS deployment
> target or SDK, 10.something?  I'm just wondering if our feature
> detection is working correctly on macOS/x86, because I'd expect real
> preadv/pwritev to be there from 11 onwards, and 11 is already out of
> support by Apple.

There has been a lot of work on the macOS SDK in nixpkgs lately, but it 
seems that the default for x86-64 is still v10 [1], yes:

 > x86_64-darwin uses the 10.12 SDK by default, but some software is not
 > compatible with that version of the SDK. In that case, the 11.0 SDK
 > used by aarch64-darwin is available for use on x86_64-darwin. [...]

It seems like the goal is to bump x86-64 to v11 in the next release 
cycle [2].

Best,

Wolfgang

[1]: https://nixos.org/manual/nixpkgs/unstable/#sec-darwin
[2]: 
https://discourse.nixos.org/t/on-the-future-of-darwin-sdks-or-how-you-can-stop-worrying-and-put-the-sdk-in-build-inputs/50574/11