Horton

Re: Ltree syntax improvement

Nikita Glukhov <n.gluhov@postgrespro.ru>

View thread View on postgr.es
From: Nikita Glukhov <n.gluhov@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Dmitry Belyavsky <beldmit@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Thomas Munro <thomas.munro@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Nikolay Shaplov <dhyan@nataraj.su>
Date: 2020-04-03T23:26:06Z
Lists: pgsql-hackers

Attachments

On 02.04.2020 19:16, Tom Lane wrote:

> Nikita Glukhov <n.gluhov@postgrespro.ru> writes:
>> Rebased patch attached.
> Thanks for rebasing!  The cfbot's not very happy though:
>
> 4842ltxtquery_io.c: In function ‘makepol’:
> 4843ltxtquery_io.c:188:13: error: ‘escaped’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 4844  if (lenval - escaped <= 0)
> 4845             ^
> 4846ltxtquery_io.c:230:6: note: ‘escaped’ was declared here
> 4847  int   escaped;
> 4848      ^
> 4849cc1: all warnings being treated as errors
>
> 			regards, tom lane

Fixed patch attached.

-- 
Nikita Glukhov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Clean up parsing of ltree and lquery some more.