Horton
Menu

回复：回复：Fix missing initialization of delayChkptEnd

suyu.cmj <mengjuan.cmj@alibaba-inc.com>

View thread
From: 蔡梦娟(玊于) <mengjuan.cmj@alibaba-inc.com>
To: "Kyotaro Horiguchi" <horikyota.ntt@gmail.com>
Cc: "pgsql-hackers" <pgsql-hackers@lists.postgresql.org>, "robertmhaas" <robertmhaas@gmail.com>
Date: 2023-06-07T02:25:25Z
Lists: pgsql-hackers

Attachments

In my new patch for pg14, I add the assertion on delayChkptEnd in ProcArrayClearTransaction, and also add patches for release branch from 10 to 13, please check.
Thanks & Best Regard
------------------------------------------------------------------
发件人：Kyotaro Horiguchi <horikyota.ntt@gmail.com>
发送时间：2023年6月6日(星期二) 14:13
收件人：蔡梦娟(玊于) <mengjuan.cmj@alibaba-inc.com>
抄　送：pgsql-hackers <pgsql-hackers@lists.postgresql.org>; robertmhaas <robertmhaas@gmail.com>
主　题：Re: 回复：Fix missing initialization of delayChkptEnd
Good catch!
At Tue, 06 Jun 2023 00:39:47 +0800, "蔡梦娟(玊于)" <mengjuan.cmj@alibaba-inc.com> wrote in 
> Hi, all. I updated the patch for this bugfix, the previous one
> missed the modification of function InitAuxiliaryProcess, please
> check the new patch.
After a quick check through the 14 tree, then compaing with the
corresponding parts of 15, it hit me that ProcArrayClearTransaction()
needs an assertion on the variable. Other than that, the patch looks
good to me.
regards.
-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix missing initializations of MyProc.delayChkptEnd

  2. Rethink the delay-checkpoint-end mechanism in the back-branches.