Re: [HACKERS] pgbench - allow to store select results into variables
Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>,
Stephen Frost <sfrost@snowman.net>,
PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2018-08-14T19:10:14Z
Lists: pgsql-hackers
On 08/14/2018 01:44 PM, Tom Lane wrote: > Fabien COELHO <coelho@cri.ensmp.fr> writes: >> I have no doubt that some MUA around would forget to do the conversion. > FWIW, one reason that I invariably use patch(1) to apply submitted patches > is that it will take care of stripping any CRs that may have snuck in. > So I'm not particularly fussed about the problem. I also use patch(1), although probably mainly out of laziness in not changing habits going back to the CVS days ;-) You obviously commit far more patches that I do, but I don't normally see patch complaining about CRs, which is why I raised the issue. > > I'm not excited about encouraging people to use application/octet-stream > rather than text/something for submitted patches. If you use text then > the patch can easily be examined in the web archives; with > application/octet-stream the patch has to be downloaded, adding a lot of > manual overhead. (At least, that's true with my preferred web browser, > maybe it's different for other people?) > > You might have a point. Compressed patched can be particularly annoying. Most other things my browser will download and pop unto geany for me. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
pgbench: Remove \cset
- 25ee70511ec2 12.0 landed
-
pgbench: add \cset and \gset commands
- 6260cc550b0e 12.0 landed
-
Adjust pgbench to allow non-ASCII characters in variable names.
- 9d36a386608d 11.0 landed
-
Refactor script execution state machine in pgbench.
- 12788ae49e19 10.0 cited
-
Allow empty queries in pgbench.
- 6471045230f5 10.0 cited