Re: PATCH: Configurable file mode mask
David Steele <david@pgmasters.net>
From: David Steele <david@pgmasters.net>
To: Michael Paquier <michael.paquier@gmail.com>,
Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
Robert Haas <robertmhaas@gmail.com>,
"Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>,
Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>,
Pg Hackers <pgsql-hackers@postgresql.org>,
Adam Brightwell <adam.brightwell@crunchydata.com>
Date: 2018-01-23T14:18:51Z
Lists: pgsql-hackers
On 1/20/18 5:47 PM, Michael Paquier wrote: > On Fri, Jan 19, 2018 at 06:54:23PM -0300, Alvaro Herrera wrote: >> Peter Eisentraut wrote: >> If the only problem is that buildfarm would run tests twice, then I >> think we should just press forward with this regardless of that: it >> seems a chicken-and-egg problem, because buildfarm cannot be upgraded to >> use some new test method if the method doesn't exist yet. As a >> solution, let's just live with some run duplication for a period until >> the machines are upgraded to a future buildfarm client code. It also appears that the TAP tests don't have the infrastructure to be able to run pg_ugrade properly, per below. > The main complain I received about this move of the pg_upgrade tests to > be a TAP one is that they don't support easily cross-major version > upgrades, removing some abilities to what a developer or the builfarm > can actually do. Unless I read it wrong the buildfarm is not doing cross-version upgrades, but a developer/user can do so manually using the same script? > Making this possible would require first some > refactoring of PostgresNode.pm so as a node is aware of the binary paths > it uses to be able to manipulate multiple instances with different > install paths at the same time. Any idea of what the LOE would be for that? Thanks, -- -David david@pgmasters.net
Commits
-
Allow group access on PGDATA
- c37b3d08ca68 11.0 landed
-
Refactor dir/file permissions
- da9b580d8990 11.0 landed
-
Revert "Add basic TAP test setup for pg_upgrade"
- 58ffe141eb37 11.0 cited
-
Add basic TAP test setup for pg_upgrade
- f41e56c76e39 11.0 cited