Re: some grammar fixes for docs
Jonathan S. Katz <jkatz@postgresql.org>
From: "Jonathan S. Katz" <jkatz@postgresql.org>
To: Michael Paquier <michael@paquier.xyz>,
Liudmila Mantrova <l.mantrova@postgrespro.ru>
Cc: pgsql-docs@lists.postgresql.org
Date: 2019-05-16T23:36:02Z
Lists: pgsql-docs
On 5/16/19 7:32 PM, Michael Paquier wrote: > On Thu, May 16, 2019 at 05:11:37PM +0300, Liudmila Mantrova wrote: >> I have noticed imperfect grammar in a couple of sgml files, please consider >> a small patch (attached). > > Thanks, Liudmila for caring about such matters. > >> <para> >> - Transaction which last more than <replaceable>limit</replaceable> milliseconds >> + Transactions that last more than <replaceable>limit</replaceable> milliseconds >> are counted and reported separately, as <firstterm>late</firstterm>. >> </para> > > I don't see much of a difference between "which" or "that" in this > context, and you are right about the plural for "Transactions". Any > native English speaker around or anybody with an extra opinion? > >> <para> >> Of the two operator classes for type <type>point</type>, >> <literal>quad_point_ops</literal> is the default. <literal>kd_point_ops</literal> >> - supports the same operators but uses a different index data structure which >> + supports the same operators but uses a different index data structure that >> may offer better performance in some applications. >> </para> > > Same here. Technically it should be "that" - often you say "which" when one is speaking, but in writing, in the above cases, "that" is grammatically correct. Thanks, Jonathan
Commits
-
Fix some grammar in documentation of spgist
- d93ba74c22c2 9.4.23 landed
-
Fix some grammar in documentation of spgist and pgbench
- cd703f5e17d5 9.5.18 landed
- be56bf76b0f3 9.6.14 landed
- 7f920b8f71aa 10.9 landed
- 0950d25acec6 11.4 landed
- 03310dbea974 12.0 landed