Re: [PATCH] Generate random dates/times in a specified range

Vik Fearing <vik@postgresfriends.org>

From: Vik Fearing <vik@postgresfriends.org>

To: Chao Li <li.evan.chao@gmail.com>, Damien Clochard <damien@dalibo.info>

Cc: Greg Sabino Mullane <htamfids@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Dean Rasheed <dean.a.rasheed@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2025-08-29T14:14:19Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

doc: Improve description of new random(min, max) functions.
- 9c24111c4dad 19 (unreleased) landed
Add date and timestamp variants of random(min, max).
- faf071b55383 19 (unreleased) landed

On 29/08/2025 11:12, Chao Li wrote:
>
>
>> On Aug 26, 2025, at 22:17, Damien Clochard <damien@dalibo.info> wrote:
>>
>> Le 25.08.2025 15:33, Greg Sabino Mullane a écrit :
>>> Your v3 did not get attached to the previous email.
>>
>> My bad, here it is
>>
>> -- 
>> Damien 
>> Clochard<v3-0001-Generate-random-dates-times-in-a-specified-range.patch>
>
> Code change looks good to me. Maybe we can make 
> check_range_boundaries() “inline” as well.
>
> But a major problem is, I think we should bump CATALOG_VERSION_NO. 
> Otherwise, running your code with an existing database, the new 
> functions won’t work.


Traditionally, the patch committer bumps the catversion, not the patch 
author.

-- 

Vik Fearing