Re: Log a sample of transactions

Adrien Nayrat <adrien.nayrat@anayrat.info>

From: Adrien NAYRAT <adrien.nayrat@anayrat.info>

To: "Kuroda, Hayato" <kuroda.hayato@jp.fujitsu.com>, "'pgsql-hackers@lists.postgresql.org'" <pgsql-hackers@lists.postgresql.org>

Date: 2019-01-15T10:05:16Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Tweak docs for log_statement_sample_rate
- d1f04b96b99d 12.0 landed

Attachments

log_xact-2.patch (text/x-patch) patch

On 1/15/19 9:00 AM, Kuroda, Hayato wrote:
> Dear Adrien,
> 
> I applied your file and faced a bug-candidate.
> (I have not read your source yet. Sorry.)
> 
> When I tried to use tab-complition, some dirty messages were appeared.
> 
> Messages I faced are attached in this mail.
> 
> Best Regards,
> Hayato Kuroda
> Fujitsu LIMITED
> 

Hello,

Thanks for your review ;)

Your messages looks normal to me, you will have same messages if you put 
log_min_duration to 0.

However, my compiler warn me of multiple definition of xact_is_sampled. 
I fix it in this 2nd patch.

Regards,