Horton

Re: zlib detection in Meson on Windows broken?

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>, Dave Page <dpage@pgadmin.org>, Nazir Bilal Yavuz <byavuz81@gmail.com>, Tristan Partin <tristan@partin.io>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2024-05-21T19:54:52Z
Lists: pgsql-hackers 
On 2024-05-21 Tu 11:04, Andres Freund wrote:
> Hi,
>
> On 2024-05-20 11:58:05 +0100, Dave Page wrote:
>> I have very little experience with Meson, and even less interpreting it's
>> logs, but it seems to me that it's not including the extra lib and include
>> directories when it runs the test compile, given the command line it's
>> reporting:
>>
>> cl C:\Users\dpage\git\postgresql\build\meson-private\tmpg_h4xcue\testfile.c
>> /nologo /showIncludes /utf-8 /EP /nologo /showIncludes /utf-8 /EP /Od /Oi-
>>
>> Bug, or am I doing something silly?
> It's a buglet. We rely on meson's internal fallback detection of zlib, if it's
> not provided via pkg-config or cmake. But it doesn't know about our
> extra_include_dirs parameter. We should probably fix that...
>

Yeah. Meanwhile, what I got working on a totally fresh Windows + VS 
install was instead of using extra_include_dirs etc to add the relevant 
directories to the environment LIB and INCLUDE settings before calling 
`"meson setup".


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com