Horton

Re: Solaris compiler status

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-09-04T10:55:57Z
Lists: pgsql-hackers

Attachments

On 03.09.25 07:47, Peter Eisentraut wrote:
> So, can we declare that we don't support this compiler anymore?

Ok, looks like we're calling it.

Here is a patch set to remove what turns out to be a significant amount 
of code and documentation to support this compiler.

I also added in one tiny cosmetic bug fix that this compiler found, as 
its parting gift.

In passing, I also removed some version checks for no longer supported 
old GCC versions, since they touched some of the same #ifdef etc. lines.

In src/include/storage/s_lock.h, there was a comment to look in 
src/backend/port/tas/sunstudio_sparc.s for some explanation.  But the 
latter is to be removed, so I copied the comment over and tried to fit 
it in.  But I don't understand it much, and it makes some claims about 
gcc support for sparc, so it could be that some more code for newer 
sparc variants is dead, or maybe gcc has caught up in the meantime. 
Also, that cvs.opensolaris.org link no longer works.  But I think this 
all could be a separate project to sort out.

Commits

  1. Remove traces of support for Sun Studio compiler

  2. Remove checks for no longer supported GCC versions

  3. Remove stray semicolon at global scope

  4. Provide vectored variants of smgrread() and smgrwrite().

  5. Convert *GetDatum() and DatumGet*() macros to inline functions