Re: WIP: Covering + unique indexes.

Teodor Sigaev <teodor@sigaev.ru>

From: Teodor Sigaev <teodor@sigaev.ru>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Anastasia Lubennikova <a.lubennikova@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-04-08T16:31:16Z
Lists: pgsql-hackers
Thank you, fixed

Jeff Janes wrote:
> On Sat, Apr 7, 2018 at 4:02 PM, Teodor Sigaev <teodor@sigaev.ru 
> <mailto:teodor@sigaev.ru>> wrote:
> 
>     Thanks to everyone, pushed.
> 
> 
> Indeed thanks, this will be a nice feature.
> 
> It is giving me a compiler warning on non-cassert builds using gcc 
> (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609:
> 
> indextuple.c: In function 'index_truncate_tuple':
> indextuple.c:462:6: warning: unused variable 'indnatts' [-Wunused-variable]
>    int   indnatts = tupleDescriptor->natts;
> 
> Cheers,
> 
> Jeff

-- 
Teodor Sigaev                      E-mail: teodor@sigaev.ru
                                       WWW: http://www.sigaev.ru/


Commits

  1. Adjust INCLUDE index truncation comments and code.

  2. Add commentary explaining why MaxIndexTuplesPerPage calculation is safe.

  3. Indexes with INCLUDE columns and their support in B-tree

  4. Add amcheck verification of heap relations belonging to btree indexes.

  5. Doc: move info for btree opclass implementors into main documentation.

  6. Doc: mention that you can't PREPARE TRANSACTION after NOTIFY.

  7. Remove dedicated B-tree root-split record types.

  8. Restructure index access method API to hide most of it at the C level.

  9. Split _bt_insertonpg to two functions.

  10. Major overhaul of btree index code. Eliminate special BTP_CHAIN logic for