Horton

Re: Mention idle_replication_slot_timeout in pg_replication_slots docs

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: "pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>
Date: 2025-06-26T07:55:26Z
Lists: pgsql-docs

Attachments


On 2025/06/26 15:43, Hayato Kuroda (Fujitsu) wrote:
> Dear Fujii-san,
> 
>> The pg_replication_slots documentation mentions only max_slot_wal_keep_size
>> as a condition under which the wal_status column can show unreserved or lost.
>> However, since commit ac0e33136ab, idle_replication_slot_timeout can also
>> cause this behavior when it is set. This has not been documented yet.
>> https://www.postgresql.org/docs/devel/view-pg-replication-slots.html
> 
> Oh, I feel the doc should be also updated.

Thanks for the review!


>> So, how about updating the documentation to also mention
>> idle_replication_slot_timeout as a factor that can cause wal_status to
>> become unreserved or lost? Patch attached.
> 
> One comment:
> 
> ```
>           <para>
>            <literal>lost</literal> means that some required WAL files have
>            been removed and this slot is no longer usable.
>           </para>
> ```
> 
> IIUC, there is a case that status is "lost" but the required WALs have not been
> dropped yet if the slot was invalidated due to the timeout. How about removing the
> first part:
> 
> ```
> <literal>lost</literal> means that this slot is no longer usable.
> ```

Agreed. Attached is the updated version of the patch.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation

Commits

  1. doc: Update outdated descriptions of wal_status in pg_replication_slots.

  2. doc: Remove incorrect note about wal_status in pg_replication_slots.

  3. Invalidate inactive replication slots.

  4. Support invalidating replication slots due to horizon and wal_level