Horton

Re: Newline after --progress report

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-08-17T14:20:46Z
Lists: pgsql-hackers 
On 17/08/2020 16:59, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> Good point. Pushed a patch along those lines.
> 
> Uh ... you patched v12 but not v13?

Darn, I forgot it exists.

> Also, I'd recommend that you NOT do this:
> 
> +   fprintf(stderr, (!finished && isatty(fileno(stderr))) ? "\r" : "\n");
> 
> as it breaks printf format verification in many/most compilers.

Ok. I pushed the same commit to v12 as to other branches now, to keep 
them in sync. I'll go fix that as a separate commit. Thanks!

- Heikki

Commits

  1. Avoid non-constant format string argument to fprintf().

  2. Fix printing last progress report line in client programs.