Horton

Re: corruption of WAL page header is never reported

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: alvherre@alvh.no-ip.org, nagata@sraoss.co.jp, ranier.vf@gmail.com, pgsql-hackers@postgresql.org
Date: 2021-10-05T15:18:27Z
Lists: pgsql-hackers 

On 2021/10/05 10:58, Kyotaro Horiguchi wrote:
> At Tue, 5 Oct 2021 00:59:46 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in
>> I think that it's better to comment why "retry" is not necessary
>> when not in standby mode.
>>
>> -------------------
>> When not in standby mode, an invalid page header should cause recovery
>> to end, not retry reading the page, so we don't need to validate the
>> page
>> header here for the retry. Instead, ReadPageInternal() is responsible
>> for
>> the validation.
> 
> LGTM.

Thanks for the review! I updated the comment and pushed the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Make recovery report error message when invalid page header is found.

  2. Fix scenario where streaming standby gets stuck at a continuation record.