Horton

Thread

Commits

  1. doc: Mention possible ephemeral discrepancies in pg_stat_activity

  1. Doc: clarify possibility of ephemeral discrepancies between state and wait_event in pg_stat_activity

    Alex Friedman <alexf01@gmail.com> — 2025-02-26T18:12:44Z

    Hi,

This small doc change patch is following up on a past discussion about 
discrepancies between state and wait_event in pg_stat_activity:

https://www.postgresql.org/message-id/flat/ab1c0a7d-e789-5ef5-1180-42708ac6fe2d%40postgrespro.ru


As this kind of question is raised by PG users from time to time, the goal is to 
clarify that such discrepancies are to be expected. The attached patch reuses 
Robert Haas's eloquent wording from his response in the above thread. I've tried 
to keep it short and to the point, but it can be made more verbose if needed.


Best regards,

Alex Friedman

  2. Re: Doc: clarify possibility of ephemeral discrepancies between state and wait_event in pg_stat_activity

    Sami Imseih <samimseih@gmail.com> — 2025-02-26T20:00:53Z

    I am not sure if the wait_event vs state relationship needs to
be documented specifically. I can think of another discrepancy
such as query_id = NULL and state = active, which occurs when
the query  is still being parsed and jumbled and a query_id is not yet
available. There are probably other ephemeral discrepancies
across all these fields.

Another common pattern is joining pg_stat_activity and pg_locks,
and that will have the same problem. Of course, these are different
views being joined, so maybe there isn't an expectation of 100%
accuracy, but worth calling this out as well.

If we do need to document anything, which I am not convinced we should,
it should be more generic.

-- 

Sami Imseih
Amazon Web Services (AWS)

  3. Re: Doc: clarify possibility of ephemeral discrepancies between state and wait_event in pg_stat_activity

    Alex Friedman <alexf01@gmail.com> — 2025-02-26T21:01:48Z

    On 26/02/2025 22:00, Sami Imseih wrote:
> If we do need to document anything, which I am not convinced we should,
> it should be more generic.

Thanks for the feedback, I've attached a v2 patch which has wording that's a bit 
more generic.

It's also worth noting that pg_locks already has a full paragraph explaining 
inconsistencies, so in my opinion it's worth it at least mentioning something 
similar here for pg_stat_activity.


Best regards,

Alex Friedman

  4. Re: Doc: clarify possibility of ephemeral discrepancies between state and wait_event in pg_stat_activity

    Sami Imseih <samimseih@gmail.com> — 2025-02-27T16:02:14Z

    > It's also worth noting that pg_locks already has a full paragraph explaining
> inconsistencies, so in my opinion it's worth it at least mentioning something
> similar here for pg_stat_activity.

yes, that is a different consistency from the one I was referring to with
regards to a join between pg_locks and pg_stat_activity, but I do
agree that it is worth calling out the expectation for pg_stat_activity.

> Thanks for the feedback, I've attached a v2 patch which has wording that's a bit
> more generic.

A few comments. I don't like the use of "lightweight" here as it is
usually referring
to LWLocks ( lightweight locks ), which can cause confusion. Also,if
we are going
to mention specific examples, I think we will need to explain further what the
discrepancy will look like. What about we do something much more
simplified, such
as the below:

"""
To keep the reporting overhead low, the system does not attempt to synchronize
activity data for a backend. As a result, ephemeral discrepancies may
exist between
the view’s columns.
"""


--
Sami Imseih
Amazon Web Services (AWS)

  5. Re: Doc: clarify possibility of ephemeral discrepancies between state and wait_event in pg_stat_activity

    Alex Friedman <alexf01@gmail.com> — 2025-03-02T10:42:17Z

    > discrepancy will look like. What about we do something much more
> simplified, such
> as the below:
> 
> """
> To keep the reporting overhead low, the system does not attempt to synchronize
> activity data for a backend. As a result, ephemeral discrepancies may
> exist between
> the view’s columns.
> """

Yes, I believe it makes sense to make it more generic. Attached v3 with a slight 
tweak:

+    in the system. To keep the reporting overhead low, the system does not 
attempt to
+    synchronize different aspects of activity data for a backend. As a result, 
ephemeral
+    discrepancies may exist between the view's columns.


Best regards,

Alex Friedman

  6. Re: Doc: clarify possibility of ephemeral discrepancies between state and wait_event in pg_stat_activity

    Sami Imseih <samimseih@gmail.com> — 2025-03-03T17:35:15Z

    Thanks for the update. This LGTM! and I will mark as RFC.

--
Sami

  7. Re: Doc: clarify possibility of ephemeral discrepancies between state and wait_event in pg_stat_activity

    Michael Paquier <michael@paquier.xyz> — 2025-03-26T23:09:12Z

    On Mon, Mar 03, 2025 at 11:35:15AM -0600, Sami Imseih wrote:
> Thanks for the update. This LGTM! and I will mark as RFC.

Yes, agreed that there is no specific need to be precise about the
attributes that can become inconsistent, as this would also depend on
the addition of more states, or event more attributes.

The wording of v3 is OK by me, so applied.  Perhaps this could be
tweaked more, so if there are any comments, feel free.
--
Michael