Horton

Re: TRUNCATE on foreign table

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Kohei KaiGai <kaigai@heterodb.com>, Kazutaka Onishi <onishi@heterodb.com>, Zhihong Yu <zyu@yugabyte.com>, Amit Langote <amitlangote09@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: 2021-04-27T09:40:49Z
Lists: pgsql-hackers 

On 2021/04/27 15:02, Bharath Rupireddy wrote:
> On Tue, Apr 27, 2021 at 11:19 AM Fujii Masao
> <masao.fujii@oss.nttdata.com> wrote:
>>> In docs v4 patch, I think we can combine below two lines into a single line:
>>> +   supported by the foreign data wrapper,
>>>       see <xref linkend="postgres-fdw"/>.
>>
>> You mean "supported by the foreign data wrapper <xref linkend="postgres-fdw"/>"?
>>
>> I was thinking that it's better to separate them because postgres_fdw
>> is just an example of the foreign data wrapper supporting TRUNCATE.
>> This makes me think again; isn't it better to add "for example" or
>> "for instance" into after "data wrapper"? That is,
>>
>>       <command>TRUNCATE</command> can be used for foreign tables if
>>       supported by the foreign data wrapper, for instance,
>>       see <xref linkend="postgres-fdw"/>.
> 
> +1.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. doc: Review for "Allow TRUNCATE command to truncate foreign tables".

  2. Don't pass "ONLY" options specified in TRUNCATE to foreign data wrapper.

  3. Support tab-complete for TRUNCATE on foreign tables.

  4. Allow TRUNCATE command to truncate foreign tables.

  5. Add support for asynchronous execution.