Horton

Re: Add notes to pg_combinebackup docs

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, Martín Marqués <martin.marques@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-04-24T19:08:27Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_combinebackup: Detect checksum mismatches and document limitation.

  2. Remove spurious "the".

> On 22 Apr 2024, at 20:52, Robert Haas <robertmhaas@gmail.com> wrote:
> 
> On Thu, Apr 18, 2024 at 3:25 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>>> On 18 Apr 2024, at 20:11, Robert Haas <robertmhaas@gmail.com> wrote:
>>> 2. As (1), but make check_control_files() emit a warning message when
>>> the problem case is detected.
>> 
>> Being in the post-freeze part of the cycle, this seems like the best option.
> 
> Here is a patch for that.

LGTM; only one small comment which you can ignore if you feel it's not worth
the extra words.

+    <literal>pg_combinebackup</literal> when the checksum status of the
+    cluster has been changed; see

I would have preferred that this sentence included the problematic period for
the change, perhaps "..has been changed after the initial backup." or ideally
something even better.  In other words, clarifying that if checksums were
enabled before any backups were taken this limitation is not in play.  It's not
critical as the link aptly documents this, it just seems like the sentence is
cut short.

--
Daniel Gustafsson