Re: GUC for temporarily disabling event triggers
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Mikhail Gribkov <youzhick@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-03-06T12:24:56Z
Lists: pgsql-hackers
Attachments
- v4-0001-Add-GUC-for-temporarily-disabling-event-triggers.patch (application/octet-stream) patch v4-0001
> On 27 Jan 2023, at 15:00, Mikhail Gribkov <youzhick@gmail.com> wrote: > There is a complete framework for disabling various types of the event triggers separately, but, the list of valid GUC values only include 'all' and 'none'. Why not adding support for all the event trigger types separately? Everything is already there in the patch; the only thing needed is expanding couple of enums. It's cheap in terms of code size and even cheaper in terms of performance. And moreover - it would be a good example for anyone adding new trigger types. I can't exactly recall my reasoning, but I do think you're right that if we're to have this GUC it should support the types of existing EVTs. The updated v4 implements that as well as a rebase on top of master and fixing a typo discovered upthread. -- Daniel Gustafsson
Commits
-
Add GUC for temporarily disabling event triggers
- 7750fefdb2b8 17.0 landed
-
Fix typos in code and comments
- 5f6401f81cb2 16.0 cited