Re: Changing the state of data checksums in a running cluster

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Michael Banck <mbanck@gmx.net>

Cc: Tomas Vondra <tomas@vondra.me>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-10-07T09:42:41Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Use correct datatype for PID
- 0ca1b3010597 19 (unreleased) landed
Improve comments in online checksums code
- cd857dec0e0a 19 (unreleased) landed
Fix checksum state transition during promotion
- 5fee7cab1b87 19 (unreleased) landed
Fix regex searching for page verification failures in tests
- 486b9a9b9eb4 19 (unreleased) landed
Apply data-checksum worker throttling parameters
- 9a39056c418c 19 (unreleased) landed
Skip WAL for unlogged main fork during online checksum enable
- 2018bd616790 19 (unreleased) landed
Revert "Get rid of WALBufMappingLock"
- c13070a27b63 19 (unreleased) cited
Get rid of WALBufMappingLock
- bc22dc0e0ddc 18.0 cited
Improve grammar of options for command arrays in TAP tests
- ce1b0f9da03e 18.0 cited

Attachments

v3-0001-Support-checksum-enable-disable-in-a-running-clus.patch (application/octet-stream) patch v3-0001

> On 1 Oct 2024, at 20:55, Daniel Gustafsson <daniel@yesql.se> wrote:
> 
>> On 1 Oct 2024, at 00:43, Michael Banck <mbanck@gmx.net> wrote:
>> 
>> Hi,
>> 
>> On Mon, Sep 30, 2024 at 11:21:30PM +0200, Daniel Gustafsson wrote:
>>>> Yeah, I think a view like pg_stat_progress_checksums would work.
>>> 
>>> Added in the attached version.  It probably needs some polish (the docs for
>>> sure do) but it's at least a start.
>> 
>> Just a nitpick, but we call it data_checksums about everywhere, but the
>> new view is called pg_stat_progress_datachecksums - I think
>> pg_stat_progress_data_checksums would look better even if it gets quite
>> long.
> 
> That's a fair point, I'll make sure to switch for the next version of the
> patch.

A rebased v3 attached with that change.

--
Daniel Gustafsson