Horton

Re: MSVC SSL test failure

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Alexander Lakhin <exclusion@gmail.com>, Lars Kanis <lars@greiz-reinsdorf.de>
Date: 2021-12-06T15:09:31Z
Lists: pgsql-hackers 
> On 6 Dec 2021, at 15:56, Andrew Dunstan <andrew@dunslane.net> wrote:

> Yeah, quite annoying, especially because only some combinations of MSVC
> runtime / openssl version seem to trigger the problem.
> 
> Adding a shutdown() before the closesocket() also fixes the issue.

If you have a patch you're testing I'm happy to run it through Cirrus in as
many combinations of MSVC and OpenSSL as I can muster there.

--
Daniel Gustafsson		https://vmware.com/

Commits

  1. On Windows, also call shutdown() while closing the client socket.

  2. On Windows, close the client socket explicitly during backend shutdown.